shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests

MIT License

1.44k stars 185 forks source link

Add an entryNameKeys option #113

Closed jacobwindsor closed 3 years ago

jacobwindsor commented 6 years ago

Addresses #110

codecov-io commented 6 years ago

Codecov Report

Merging #113 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          78     78           
=====================================
  Hits           78     78

Impacted Files	Coverage Δ
lib/plugin.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 409b0fb...ea6a382. Read the comment docs.

jacobwindsor commented 6 years ago

In the previous commit I have simply excluded sourcemaps from having their extension excluded. I realised that after excluding the extension, each key in the manifest would point to the sourcemap file and not the source since the former is processed after.

I don't think this is the best way to go. Instead, I would prefer something like:

{
   entryName: {
    source: 'main.js'
    sourceMap: 'main.js.map'
  }
}

However, that's a fairly large change and might warrant another PR entirely.

shellscape commented 3 years ago

@jacobwindsor Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've landed a major refactor in #222 that has resulted in some significant conflicts. Would you be interested in reworking your PR on top of the new codebase?

shellscape commented 3 years ago

Closed by a998c4bbd205d0bbf3c19b567ce259894c1502d0