shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

ReferenceError: fs is not defined #12

Closed jordaaash closed 8 years ago

jordaaash commented 8 years ago

fd87e2da0f62861291ac75b7fbac6748f4a75a45 removed require('fs').

Not a good idea to remove imports for things that are still in the file without tests.

jordaaash commented 8 years ago

56adb73b647b9ac4d6d87529173cf8ccbd7903eb doesn't completely fix this.

Now I'm getting ReferenceError: outputPath is not defined

jordaaash commented 8 years ago

Fixed by f3ce4d36930d42d67988a3cdeefb6b36234e8f63 from #13

jordaaash commented 8 years ago

I'm actually closing this in favor of #14. The issue is that #6 broke the readFile option because the file doesn't exist during the compiler's emit phase.