shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 185 forks source link

move emitCountMap to support multiple webpack configs #146

Closed philiplehmann closed 6 years ago

philiplehmann commented 6 years ago

only one manifest file was written for multiple configs:

const Webpack = require('webpack')
const WebpackDevServer = require('webpack-dev-server')
const config1 = {...}
const config2 = {...}
const config3 = {...}
const config4 = {...}

const compiler = Webpack([config1, config2, config3, config4])
const server = new WebpackDevServer(compiler, devServerConfig)
server.listen(PORT, HOST)

moved the emitCountMap into the apply function. before it was global and shared between the plugin instances.

mastilver commented 6 years ago

It should already support multiple configs, see: https://github.com/danethurber/webpack-manifest-plugin/blob/master/spec/plugin.integration.spec.js#L247

philiplehmann commented 6 years ago

what i wanted is to get a manifest file for each configuration. which it did in a earlier version. maybe an option would be better. i see now, that this was changed intentional.

mastilver commented 6 years ago

I fail to understand what you want... the example you provided above should work. Can you send us a failing test so we can look into it

philiplehmann commented 6 years ago

sounds good

will do the changes

codecov-io commented 6 years ago

Codecov Report

Merging #146 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #146   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         110    110           
  Branches       21     21           
=====================================
  Hits          110    110
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbab79e...a631bfc. Read the comment docs.