search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.43k stars 185 forks source link

feat: supports overwriting outputPath of the manifest.json #149

Closed ymschaap closed 6 years ago

ymschaap commented 6 years ago

I'm in the situation where the manifest should be written to a different path then the default Webpack (output) path.

This option is also supported by assets-webpack-plugin but it seems to not support Webpack 4 properly.

This PR is similar to #139, but misses the changes to plugin.spec.js because I'm not familiar with the test suite.

codecov-io commented 6 years ago

Codecov Report

Merging #149 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #149   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         110    110           
  Branches       21     22    +1     
=====================================
  Hits          110    110
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95d94ef...4320e2a. Read the comment docs.

ymschaap commented 6 years ago

Too soon! I'll do more testing before re-open PR.

mastilver commented 6 years ago

Do you know you can use an absolute path for fileName Feel free to send a PR to improve the docs ;)

ymschaap commented 6 years ago

Great suggestion. I didn't know. And I like it!