Scope hoisting webpack 4 - Githubissues

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests

MIT License

1.44k stars 185 forks source link

Scope hoisting webpack 4 #151

Closed bugzpodder closed 6 years ago

bugzpodder commented 6 years ago

https://github.com/facebook/create-react-app/issues/4492 https://github.com/facebook/create-react-app/pull/4077#issuecomment-389270627

concatenateModules option is on by default in production
import in SvgComponent produces ConcatenatedModule (rather than a NormalModule).
ConcatenatedModule doesn't have userRequest field for webpack-manifest-plugin, which crashes.

petetnt commented 6 years ago

Related? https://github.com/danethurber/webpack-manifest-plugin/pull/117

bugzpodder commented 6 years ago

Yes, looks like the same issue.