search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.43k stars 186 forks source link

remove .bind and map -> forEach #154

Closed caub closed 3 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #154 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #154   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         111    108    -3     
  Branches       22     22           
=====================================
- Hits          111    108    -3
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cad06c8...f8193a0. Read the comment docs.

shellscape commented 3 years ago

Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've landed a major refactor in #222 that has resulted in some significant changes, and some which has rendered your changes in this PR unneeded. Thanks again for contributing and I hope you'll consider doing so again in the future.