search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.43k stars 186 forks source link

v3 #197

Closed mastilver closed 3 years ago

mastilver commented 4 years ago

closes #195 fixes #167

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@41036d5). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage          ?   99.06%           
=========================================
  Files             ?        2           
  Lines             ?      107           
  Branches          ?       22           
=========================================
  Hits              ?      106           
  Misses            ?        1           
  Partials          ?        0
Impacted Files Coverage Δ
lib/plugin.js 99.05% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41036d5...21bc5cd. Read the comment docs.

Lyrkan commented 4 years ago

The webpack@next are now broken because of https://github.com/webpack/webpack/pull/9689

Replacing sourcemap by source-map here should do the trick:

https://github.com/danethurber/webpack-manifest-plugin/blob/5715c07748a80dae583074304e306534eac1896a/spec/plugin.spec.js#L121

shellscape commented 3 years ago

Closing for now, will take a look at the branch when we're ready to go that route. Please see #222 for more info.