search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.43k stars 186 forks source link

Quick fix for #186 #205

Closed kirill-konshin closed 4 years ago

mastilver commented 4 years ago

please add a test also should probably target next

kirill-konshin commented 4 years ago

Changed base to next. Can you suggest any existing test that I can take as example?

mastilver commented 4 years ago

I think https://github.com/danethurber/webpack-manifest-plugin/blob/5715c07748a80dae583074304e306534eac1896a/spec/plugin.spec.js#L68 is a good place to start

Could you rebase on next, tests picking the right configuration

kirill-konshin commented 4 years ago

The problem is that I have no idea how to force plugin in the state when asset.chunks is not defined.

mastilver commented 4 years ago

Thank you, I just wanted to confirm it was an actual issue and it just happens that master started failing on this