search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

fix: recursively extract all assets from all child compilations #211

Closed wood1986 closed 4 years ago

wood1986 commented 4 years ago

fix #210

codecov-io commented 4 years ago

Codecov Report

Merging #211 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #211   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         128    132    +4     
  Branches       26     26           
=====================================
+ Hits          128    132    +4
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b55ac5d...4a6cb46. Read the comment docs.

shellscape commented 4 years ago

@wood1986 Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've landed a major refactor in #222 that has resulted in some significant conflicts. Moving forward, we'll recommend the fix mentioned in https://github.com/shellscape/webpack-manifest-plugin/issues/210#issuecomment-641846388