search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

Read publicPath from stats to handle [hash] #215

Closed maloguertin closed 4 years ago

maloguertin commented 4 years ago

This is a PR related to this issue I reported earlier: https://github.com/danethurber/webpack-manifest-plugin/issues/214

The fix is pretty straight forward, read publicPath from stats in order to handle the [hash] placeholders.

codecov-io commented 4 years ago

Codecov Report

Merging #215 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #215   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         128    128           
  Branches       26     26           
=====================================
  Hits          128    128
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b55ac5d...57ad037. Read the comment docs.

maloguertin commented 4 years ago

Is this repo still managed?

shellscape commented 4 years ago

@maloguertin Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. (I recently took over maintenance of this repo). We've landed a major refactor in #222 that has resulted in some significant conflicts. Would you be interested in reworking your PR on top of the new codebase?

maloguertin commented 4 years ago

@maloguertin Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. (I recently took over maintenance of this repo). We've landed a major refactor in #222 that has resulted in some significant conflicts. Would you be interested in reworking your PR on top of the new codebase?

I will try to get around to it in the next weeks