shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.43k stars 186 forks source link

fix: properly join publicPath, basePath #277

Closed MoyuScript closed 2 years ago

MoyuScript commented 2 years ago

This PR contains:

Are tests included?

Breaking Changes?

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

When output.publicPath is not ends with /, the path of output will be incorrect.

Webpack configuration:

output: {
   publicPath: '/public/js'
 },

Wrong output:

{
  "index.js": "/public/jsindex.04565a72d083184c3c5a.js"
}

Correct output:

{
  "index.js": "/public/js/index.04565a72d083184c3c5a.js"
}
shellscape commented 2 years ago

Thanks for the PR. Looks like you have a few failing tests to address before we can accept it.

shellscape commented 2 years ago

thanks!