search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

Typescript typings incompatible with webpack 5. #279

Closed wegry closed 2 years ago

wegry commented 3 years ago

https://github.com/wegry/webpack-5typescript-types-breaking-webpack-manifest-plugin/tree/main

Expected Behavior

webpack-manifest-plugin should compile with tsc with webpack@5.

Actual Behavior

webpack-manifest-plugin seems to be using webpack 4 typings instead.

Additional Information

Originally I ran into this issue in yarn 3 with nodeLinker: node-modules. The repro repo is yarn 1 though.

shellscape commented 3 years ago

Yeah I doubt we'll be able to resolve that until we drop Webpack v4 support.

SunHuawei commented 2 years ago

I'm experiencing the same issue. So, is there any plan?

shellscape commented 2 years ago

@SunHuawei did you read my last reply?

SunHuawei commented 2 years ago

@shellscape , yes, I did. I mean is there a plan to drop v4 support? I know that's not easy for the existing user, however, due to that it's a breaking change, is that possible to just upgrade to v5 for this plugin to support webpack@5. That would be perfect for both v4 and v5 users.

shellscape commented 2 years ago

I don't currently have the motivation to make that change.

SunHuawei commented 2 years ago

I don't get it, do you mean you don't see any value in it? Or, you're too busy? Honestly, I love this project, and I need it very much. If you can help review and merge, I can spend some time doing that upgrade. What do you think?

shellscape commented 2 years ago

community contribution is always welcome

stale[bot] commented 2 years ago

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ

SunHuawei commented 2 years ago

I've submitted a PR here https://github.com/shellscape/webpack-manifest-plugin/pull/289.

shellscape commented 2 years ago

Closed in #289