shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.43k stars 185 forks source link

fix: Pass `chunkGraph` through in `generate` function #300

Closed pgoldberg closed 3 months ago

pgoldberg commented 1 year ago

This PR contains:

Are tests included?

Breaking Changes?

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Webpack 5 deprecated a lot of the APIs that exist on chunks, and instead prefers the use of the ChunkGraph API. We have a few places where we use now-deprecated APIs in our usage of the WebpackManifestPlugin, and would like to move those over to using the ChunkGraph API.

This PR passes through the chunkGraph in the generate function

shellscape commented 1 year ago

Thanks for the PR. Looks like a failing test is holding this up.

pgoldberg commented 1 year ago

@shellscape Thanks for reviewing! Sorry this fell off my radar a little bit – just fixed up the test issue 🙂