shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

Do not add code splitting bundles into manifest #46

Closed a-x- closed 7 years ago

a-x- commented 7 years ago

I want to use require.ensure for separating some large modules as DLL. But webpack-manifest-plugin add it into manifest so chunks are loading immediately

gmac commented 7 years ago

There are many cases for knowing all built files that came out of webpack, so it seems to me that this should be made an option allowing non-initial chunk reports to be turned off.

a-x- commented 7 years ago

yep, I agree, me PR was optional initially

Can you name the flag? I proposed this one: omitDll: true

gmac commented 7 years ago

That's certainly succinct. More verbose but possibly more obvious would be omitNonInitialChunks or omitNonEntryChunks

mastilver commented 7 years ago

I personally prefer to reduce the number of options we add (the reason I closed #43 ), and have this:

filter: ({chunk, file}) => {
  return chunk.isInitial();
}

But if you think that should be added then fine ;)

a-x- commented 7 years ago

in other words, do you propose to make this behavior default in next major version and recommend to use chunk-manifest-webpack-plugin for chunks handling?

correct me, please

p.s. I agree with this point

mastilver commented 7 years ago

Yes make it default and use filter to filter out unneeded ones