search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

Removing lodash dependency #58

Closed gmac closed 4 years ago

gmac commented 7 years ago

With this plugin gaining traction as a significant webpack/webpacker resource, seems like time to do some housekeeping that trims it down. This removes Lodash.

closes #53

mastilver commented 7 years ago

I think this should be done as part of #53

Let's leave it open for now, we will merge it when we are ready to release v2! :)

codecov-io commented 7 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.12%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   92.98%   92.85%   -0.13%     
==========================================
  Files           2        2              
  Lines          57       56       -1     
==========================================
- Hits           53       52       -1     
  Misses          4        4
Impacted Files Coverage Δ
lib/plugin.js 92.72% <100%> (-0.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdb5758...e1a5b09. Read the comment docs.

mastilver commented 7 years ago

@gmac I already deprecated node@0.10 and node@0.12, but I didn't do any code change So your PR is still valid and can be merged after 2.x as it won't be a breaking change (or before if you have time to work on it ;)

andriijas commented 6 years ago

@mastilver merge? :)