shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests

MIT License

1.44k stars 184 forks source link

Fix default manifest file mapping (path to name) #71

Closed frequin closed 7 years ago

frequin commented 7 years ago

closes #70

mastilver commented 7 years ago

Thank you @frequin , I think you are right, I must have inverted something here...

But it's not in the reduce Could you rebase on 1.x branch and add a test so it doesn't happens in the future :)

mastilver commented 7 years ago

@frequin This is where the issue lives: https://github.com/danethurber/webpack-manifest-plugin/blob/43b48f1eab84d718439383fa52a683c79e237fab/lib/plugin.js#L88-L89

frequin commented 7 years ago

@mastilver rebased and fixed. I'll add a test asap.

mastilver commented 7 years ago

Great! :)

I think minimal test would be to copy https://github.com/danethurber/webpack-manifest-plugin/blob/43b48f1eab84d718439383fa52a683c79e237fab/spec/plugin.spec.js#L345-L363

and add [hash]

codecov-io commented 7 years ago

Codecov Report

Merging #71 into 1.x will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.x      #71   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files           2        2           
  Lines          75       75           
=======================================
  Hits           74       74           
  Misses          1        1

Impacted Files	Coverage Δ
lib/plugin.js	`98.64% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c7c166...500a10d. Read the comment docs.

frequin commented 7 years ago

@mastilver There it is :)

mastilver commented 7 years ago

Great, Thank you @frequin