search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

feat(plugin): Add plugin hook to allow other plugins to use the manifest #76

Closed D34THWINGS closed 7 years ago

D34THWINGS commented 7 years ago

Hello there πŸ˜ƒ

My team has very specific needs for our build process and we are currently developing a Webpack Plugin that needs the entry and output filenames. We could do this on our own but it would be pointless to duplicate the code that is in the webpack-manifest-plugin. So we make a proposal to add a Webpack plugin hook to your plugin that will allow any plugin to hook itself to yours to pull the manifest.

I used the applyPluginsAsync function because the hook that I registered is post emit so no transformation could be applied and therefore there's no need to use waterfall or series.

I thought about adding also a hook before Json.stringify but I think that there's more probability that webpack-manifest-plugin hooks on other plugins to generate the manifest than other plugins hooking to webpack-manifest-plugin to edit it.

The hook is webpack-manifest-plugin-after-emit with one argument containing the whole manifest.

Does it sounds good to you ?

Thanks for your work !

codecov-io commented 7 years ago

Codecov Report

Merging #76 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files           2        2           
  Lines          70       70           
=======================================
  Hits           69       69           
  Misses          1        1
Impacted Files Coverage Ξ”
lib/plugin.js 98.55% <100%> (ΓΈ) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 04916cd...62d8ad4. Read the comment docs.

mastilver commented 7 years ago

Yep, I thought we would need something like that one day πŸ‘

Would you mind adding a test please

D34THWINGS commented 7 years ago

@mastilver yeah I fogot it, now it's done !

For contributors, would you like to have a basic eslint linting configuration ? It would ensure codestyle is matching with what's already in place (no missing semi, identation, make sure no ES6 feature is used, etc). I can do a pull request if you want

mastilver commented 7 years ago

yep, already started in #67 (let me know what you think there) but I want to get 2.x out of the door first, then think about code style

PatrickMennen commented 6 years ago

Since this was merged, is it also possible to publish a new release on NPM? Testing with the locally changed file the emitter works (which is nice!) but I would rather not modify third party packages in my project.