search

shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests
MIT License
1.44k stars 184 forks source link

feat: deprecate publicPath in flavour of webpack's #80

Closed mastilver closed 6 years ago

mastilver commented 6 years ago

BREAKING CHANGE: deprecate webpack-manifest-plugin's publicPath options in flavour of webpack's output.publicPAth

closes #65

codecov-io commented 6 years ago

Codecov Report

Merging #80 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   98.57%   98.59%   +0.02%     
==========================================
  Files           2        2              
  Lines          70       71       +1     
==========================================
+ Hits           69       70       +1     
  Misses          1        1
Impacted Files Coverage Δ
lib/plugin.js 98.57% <100%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de15a87...977214f. Read the comment docs.

rossta commented 6 years ago

@mastilver Plans to release this feature soon?

mastilver commented 6 years ago

Hi @rossta

release plan: v2.0.0.rc-1 by the end of the week v2.0.0 next week

rossta commented 6 years ago

@mastilver Thanks for the response and the all the hard work on the project!

s00d commented 6 years ago

thank you for breaking everything :(