shellscape / webpack-manifest-plugin

webpack plugin for generating asset manifests

MIT License

1.44k stars 184 forks source link

adds topological sort example #93

Closed SeeThruHead closed 3 years ago

SeeThruHead commented 6 years ago

add topological sort to new examples folder adds examples readme entry with link to specific example gitignore example output files

prior work: #79

codecov-io commented 6 years ago

Codecov Report

Merging #93 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #93   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          78     78           
=====================================
  Hits           78     78

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed72f68...6f339a4. Read the comment docs.

SeeThruHead commented 6 years ago

i can take a look at this tmrw. what better way to spend my airport wait :D

mastilver commented 6 years ago

Hey @SeeThruHead :)

Let me know how you are getting on with that. Do you want me to take it over (I will have more time in a couple of weeks)?

SeeThruHead commented 6 years ago

hey @mastilver I made a comment above asking for some guidance with how to test an isChunk guard. ie what kind of dep tree would give me files without chunks.

akrawchyk commented 6 years ago

This is really good stuff, I'd love to see it get merged so it gets more visibility!

One thing I noticed in the example is there is a manifest.concat() call, and according to the current docs that should be an Object not an Array so this example will fail.

It's my first time trying this plugin, so maybe that is for a different version? Wondering if this PR needs some TLC before it gets merged.

caub commented 6 years ago

it's a bit brutal, but I've done it here https://github.com/caub/webpack-manifest-plugin/blob/m2/lib/plugin.js (the logic actually mostly copied from HtmlWebpackPlugin)

I think the manifest file deserves to be sorted by default, I couldn't use the generate option easily

mastilver commented 6 years ago

html-webpack-plugin is getting rid of toposort in flavours of entrypoints, we should do the same for this plugin I believe

caub commented 6 years ago

I think it's possible to get rid of it only with webpack4, but not sure

shellscape commented 3 years ago

@SeeThruHead Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've just landed a major refactor in #222, and part of that is only supporting webpack v4.44.0+. Please let me know if you're interested in reopening this PR and we'll move forward.