Email notification of comments

shelterit / xsiteable

xSiteable

Other

3 stars 1 forks source link

Email notification of comments #25

Closed davidmac76 closed 10 years ago

davidmac76 commented 11 years ago

Would be great to have email notification of comments. Users would receive notifications they are subscribed to the page/news-item/document/forum. they would be subscribed if:

They created the page or news item They are the document owner They have commented on that page, news item, or document It is their profile page They have chosen to subscribe, by clicking a "subscribe" button

All of the above doesn't need to be implemented immediately. Priority should be:

Notification of comments on documents to document owner Notification of comments on news item to news item creator

shelterit commented 10 years ago

Mostly implemented, apart from the manual subscription option. I'd move subscription into a separate feature request.

davidmac76 commented 10 years ago

How do I get this to work? I thought the on_comment_new trigger wasn't working?

On Wed, Feb 12, 2014 at 9:23 AM, Alexander Johannesen < notifications@github.com> wrote:

Mostly implemented, apart from the manual subscription option. I'd move subscription into a separate feature request.

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34815751 .

shelterit commented 10 years ago

I've checked in code on Monday (?) that ;

trigger a generic on_comment_new event (with a topic context for the item in question, so you could take out the $topic/name and use that), or
trigger a on_commentnew{type}, where type would be 'news', 'forum', 'page', and so forth, and through that you could trigger emails that are directed at those types

Cheers,

Alex

On Wed, Feb 12, 2014 at 10:24 AM, davidmac26 notifications@github.comwrote:

How do I get this to work? I thought the on_comment_new trigger wasn't working?

On Wed, Feb 12, 2014 at 9:23 AM, Alexander Johannesen < notifications@github.com> wrote:

Mostly implemented, apart from the manual subscription option. I'd move subscription into a separate feature request.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34815751>

.

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34821311 .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

davidmac76 commented 10 years ago

There hasn't been a checkin since February 7th.

On Wed, Feb 12, 2014 at 10:28 AM, Alexander Johannesen < notifications@github.com> wrote:

I've checked in code on Monday (?) that ;

trigger a generic on_comment_new event (with a topic context for the item in question, so you could take out the $topic/name and use that), or

trigger a on_commentnew{type}, where type would be 'news', 'forum', 'page', and so forth, and through that you could trigger emails that are directed at those types

Cheers,

Alex

On Wed, Feb 12, 2014 at 10:24 AM, davidmac26 notifications@github.comwrote:

How do I get this to work? I thought the on_comment_new trigger wasn't working?

On Wed, Feb 12, 2014 at 9:23 AM, Alexander Johannesen < notifications@github.com> wrote:

Mostly implemented, apart from the manual subscription option. I'd move subscription into a separate feature request.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34815751>

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34821311> .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34821628 .

shelterit commented 10 years ago

Then that's when I checked it in. :)

Alex

On Wed, Feb 12, 2014 at 10:33 AM, davidmac26 notifications@github.comwrote:

There hasn't been a checkin since February 7th.

On Wed, Feb 12, 2014 at 10:28 AM, Alexander Johannesen <

notifications@github.com> wrote:

I've checked in code on Monday (?) that ;

trigger a generic on_comment_new event (with a topic context for the item in question, so you could take out the $topic/name and use that), or

trigger a on_commentnew{type}, where type would be 'news', 'forum', 'page', and so forth, and through that you could trigger emails that are directed at those types

Cheers,

Alex

On Wed, Feb 12, 2014 at 10:24 AM, davidmac26 <notifications@github.com wrote:

How do I get this to work? I thought the on_comment_new trigger wasn't working?

On Wed, Feb 12, 2014 at 9:23 AM, Alexander Johannesen < notifications@github.com> wrote:

Mostly implemented, apart from the manual subscription option. I'd move subscription into a separate feature request.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34815751

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34821311>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34821628>

.

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34821982 .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

davidmac76 commented 10 years ago

I've tried this:

on_comment_new_news[template] = '17696' on_comment_new_news[to] = 'user:myuser'

and it doesn't seem to work. I've set up the template (on topic 17696) and the other triggers are working fine.

On Wed, Feb 12, 2014 at 10:35 AM, Alexander Johannesen < notifications@github.com> wrote:

Then that's when I checked it in. :)

Alex

On Wed, Feb 12, 2014 at 10:33 AM, davidmac26 notifications@github.comwrote:

There hasn't been a checkin since February 7th.

On Wed, Feb 12, 2014 at 10:28 AM, Alexander Johannesen <

notifications@github.com> wrote:

I've checked in code on Monday (?) that ;

trigger a generic on_comment_new event (with a topic context for the item in question, so you could take out the $topic/name and use that), or

trigger a on_commentnew{type}, where type would be 'news', 'forum', 'page', and so forth, and through that you could trigger emails that are directed at those types

Cheers,

Alex

On Wed, Feb 12, 2014 at 10:24 AM, davidmac26 <notifications@github.com wrote:

How do I get this to work? I thought the on_comment_new trigger wasn't working?

On Wed, Feb 12, 2014 at 9:23 AM, Alexander Johannesen < notifications@github.com> wrote:

Mostly implemented, apart from the manual subscription option. I'd move subscription into a separate feature request.

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34815751

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34821311

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34821628>

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34821982>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34822182 .

davidmac76 commented 10 years ago

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

shelterit commented 10 years ago

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 notifications@github.comwrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230 .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

davidmac76 commented 10 years ago

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 <notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384 .

shelterit commented 10 years ago

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 notifications@github.comwrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 <notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384>

.

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874 .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

davidmac76 commented 10 years ago

Okay, on_comment_new_news works.... now how do I get the notification to go to the person who posted the news item?

On Wed, Feb 12, 2014 at 11:16 AM, Alexander Johannesen < notifications@github.com> wrote:

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 notifications@github.comwrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 <notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384>

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34824999 .

shelterit commented 10 years ago

Do a quick checkout, and you can use ;

"user:m_c_who", or "user:m_u_who", or "user:m_p_who"

(created, updated, published person, respectively. I'd just use "user:m_c_who|user:m_u_who")

Alex

On Wed, Feb 12, 2014 at 11:31 AM, davidmac26 notifications@github.comwrote:

Okay, on_comment_new_news works.... now how do I get the notification to go to the person who posted the news item?

On Wed, Feb 12, 2014 at 11:16 AM, Alexander Johannesen <

notifications@github.com> wrote:

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 <notifications@github.com wrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 < notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34824999>

.

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34825925 .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

davidmac76 commented 10 years ago

Nothing to check out.

On Wed, Feb 12, 2014 at 11:40 AM, Alexander Johannesen < notifications@github.com> wrote:

Do a quick checkout, and you can use ;

"user:m_c_who", or "user:m_u_who", or "user:m_p_who"

(created, updated, published person, respectively. I'd just use "user:m_c_who|user:m_u_who")

Alex

On Wed, Feb 12, 2014 at 11:31 AM, davidmac26 notifications@github.comwrote:

Okay, on_comment_new_news works.... now how do I get the notification to go to the person who posted the news item?

On Wed, Feb 12, 2014 at 11:16 AM, Alexander Johannesen <

notifications@github.com> wrote:

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 <notifications@github.com wrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 < notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34824999>

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34825925>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34826513 .

shelterit commented 10 years ago

Odd. Try now.

Alex

On Wed, Feb 12, 2014 at 11:46 AM, davidmac26 notifications@github.comwrote:

Nothing to check out.

On Wed, Feb 12, 2014 at 11:40 AM, Alexander Johannesen <

notifications@github.com> wrote:

Do a quick checkout, and you can use ;

"user:m_c_who", or "user:m_u_who", or "user:m_p_who"

(created, updated, published person, respectively. I'd just use "user:m_c_who|user:m_u_who")

Alex

On Wed, Feb 12, 2014 at 11:31 AM, davidmac26 <notifications@github.com wrote:

Okay, on_comment_new_news works.... now how do I get the notification to go to the person who posted the news item?

On Wed, Feb 12, 2014 at 11:16 AM, Alexander Johannesen <

notifications@github.com> wrote:

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 < notifications@github.com wrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 < notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384

.

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34824999

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34825925>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34826513>

.

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34826834 .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

davidmac76 commented 10 years ago

Okay, I've checked out the changes, but the notification to news item creator still doesn't work. Here is the configuration settings I'm using:

on_comment_new_news[template] = '17696' on_comment_new_news[to] = 'user:m_c_who|user:m_u_who'

On Wed, Feb 12, 2014 at 11:53 AM, Alexander Johannesen < notifications@github.com> wrote:

Odd. Try now.

Alex

On Wed, Feb 12, 2014 at 11:46 AM, davidmac26 notifications@github.comwrote:

Nothing to check out.

On Wed, Feb 12, 2014 at 11:40 AM, Alexander Johannesen <

notifications@github.com> wrote:

Do a quick checkout, and you can use ;

"user:m_c_who", or "user:m_u_who", or "user:m_p_who"

(created, updated, published person, respectively. I'd just use "user:m_c_who|user:m_u_who")

Alex

On Wed, Feb 12, 2014 at 11:31 AM, davidmac26 <notifications@github.com wrote:

Okay, on_comment_new_news works.... now how do I get the notification to go to the person who posted the news item?

On Wed, Feb 12, 2014 at 11:16 AM, Alexander Johannesen <

notifications@github.com> wrote:

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 < notifications@github.com wrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 < notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384

.

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34824999

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34825925

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34826513>

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34826834>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34827284 .

shelterit commented 10 years ago

The config looks fine. Check out, and give it another spin; I've refined the topic selector.

Alex

On Wed, Feb 12, 2014 at 11:58 AM, davidmac26 notifications@github.comwrote:

Okay, I've checked out the changes, but the notification to news item creator still doesn't work. Here is the configuration settings I'm using:

on_comment_new_news[template] = '17696' on_comment_new_news[to] = 'user:m_c_who|user:m_u_who'

On Wed, Feb 12, 2014 at 11:53 AM, Alexander Johannesen <

notifications@github.com> wrote:

Odd. Try now.

Alex

On Wed, Feb 12, 2014 at 11:46 AM, davidmac26 <notifications@github.com wrote:

Nothing to check out.

On Wed, Feb 12, 2014 at 11:40 AM, Alexander Johannesen <

notifications@github.com> wrote:

Do a quick checkout, and you can use ;

"user:m_c_who", or "user:m_u_who", or "user:m_p_who"

(created, updated, published person, respectively. I'd just use "user:m_c_who|user:m_u_who")

Alex

On Wed, Feb 12, 2014 at 11:31 AM, davidmac26 < notifications@github.com wrote:

Okay, on_comment_new_news works.... now how do I get the notification to go to the person who posted the news item?

On Wed, Feb 12, 2014 at 11:16 AM, Alexander Johannesen <

notifications@github.com> wrote:

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 < notifications@github.com wrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 < notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384

.

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34824999

.

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34825925

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34826513

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34826834>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34827284>

.

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34827642 .

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

davidmac76 commented 10 years ago

Yep, it seems to be working now.

On Wed, Feb 12, 2014 at 1:15 PM, Alexander Johannesen < notifications@github.com> wrote:

The config looks fine. Check out, and give it another spin; I've refined the topic selector.

Alex

On Wed, Feb 12, 2014 at 11:58 AM, davidmac26 notifications@github.comwrote:

Okay, I've checked out the changes, but the notification to news item creator still doesn't work. Here is the configuration settings I'm using:

on_comment_new_news[template] = '17696' on_comment_new_news[to] = 'user:m_c_who|user:m_u_who'

On Wed, Feb 12, 2014 at 11:53 AM, Alexander Johannesen <

notifications@github.com> wrote:

Odd. Try now.

Alex

On Wed, Feb 12, 2014 at 11:46 AM, davidmac26 <notifications@github.com wrote:

Nothing to check out.

On Wed, Feb 12, 2014 at 11:40 AM, Alexander Johannesen <

notifications@github.com> wrote:

Do a quick checkout, and you can use ;

"user:m_c_who", or "user:m_u_who", or "user:m_p_who"

(created, updated, published person, respectively. I'd just use "user:m_c_who|user:m_u_who")

Alex

On Wed, Feb 12, 2014 at 11:31 AM, davidmac26 < notifications@github.com wrote:

Okay, on_comment_new_news works.... now how do I get the notification to go to the person who posted the news item?

On Wed, Feb 12, 2014 at 11:16 AM, Alexander Johannesen <

notifications@github.com> wrote:

Try now; checked in, and checked in a fix (forgot to explicit pass in event name).

Alex

On Wed, Feb 12, 2014 at 10:59 AM, davidmac26 < notifications@github.com wrote:

I dunno. Have you tried making another change to the file?

On Wed, Feb 12, 2014 at 10:52 AM, Alexander Johannesen < notifications@github.com> wrote:

Yup, it's in the comments.module.php, line 153. It tells me I can't check it in, because there's no changes. I can always force changes?

Alex

On Wed, Feb 12, 2014 at 10:49 AM, davidmac26 < notifications@github.com

wrote:

Are you sure it has been checked in? When I search the repository I can find "on_document_new" but there is no "on_comment_new"

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823230

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823384

.

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34823874

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34824999

.

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34825925

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub<

https://github.com/shelterit/xsiteable/issues/25#issuecomment-34826513

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34826834

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34827284>

.

Reply to this email directly or view it on GitHub< https://github.com/shelterit/xsiteable/issues/25#issuecomment-34827642>

.

Project Wrangler, SOA, Info Alchemist, UX, RESTafarian, Topic Maps http://shelter.nu/blog | google.com/+AlexanderJohannesen http://xsiteable.org | http://www.linkedin.com/in/shelterit

Reply to this email directly or view it on GitHubhttps://github.com/shelterit/xsiteable/issues/25#issuecomment-34832103 .