sheltermanager / asm3

Animal Shelter Manager
GNU General Public License v3.0
109 stars 67 forks source link

animallocation table is still being created with column named "By" #1510

Closed traviswparker closed 3 months ago

traviswparker commented 3 months ago

dbupdate.py update_34803 is creating table animallocation using the reserved MySQL keyword By for a column name. A later update function renames the column to MovedBy

This breaks updates from 47 on MySQL as the table is never created. Modifying update_34803 to create the column as MovedBy and rolling back the DBV config value to 34802 allows the schema update to proceed.

Should probably create the column as MovedBy and allow the later rename to fail if it is already MovedBy

bobintetley commented 3 months ago

Thanks for the feedback, updated now.