shemetz / ZoomPanOptions

FoundryVTT module for zooming and panning better
MIT License
7 stars 8 forks source link

Rotating spell templates stalls the Foundry server #18

Closed Akaito closed 3 years ago

Akaito commented 3 years ago

Similar to "BUG: Breaks when rotating token too fast #17".

If I rotate a placed template using shift + mouse wheel too far, regardless of how quickly I'm doing it, zoom/pan options will stall the Foundry server. Sometimes it recovers after a delay. Sometimes I have to manually restart the Foundry process.

I narrowed this down to absolutely being within Zoom/Pan Options by disabling modules until I could get to the minimal set that caused this. This is occurring in module version 1.4.0. I'm uncertain if this is new to this specific version, but I know I didn't used to have this problem some weeks ago.

shemetz commented 3 years ago

Well that's very concerning! I can't manage to reproduce it, though.

Could you share your options for this module?

i.e. this page:

image

Also - what is your browser, your foundry version, and does this happen even with no other modules running?

Akaito commented 3 years ago

Screenshot taken while I have my normal modules enabled, but I did confirm this happened with as little as Zoom/Pan Options and "Tidy UI - Game Settings". I've also now seen it from Firefox on Windows 10, and Firefox on Linux Mint.

I'll email you a URL and user/password for a guest player to see if it repros for you there. This is on a server that runs 24/7, though I do occasionally back out of the world to update modules, etc.

2021-02-03_17-07-46

shemetz commented 3 years ago

Fixed, in 1.5.0, hopefully. If not, reopen the ticket. Thanks a lot for giving me access to your server to help debug it, even though at the end I think I found the problem just by looking at the code differences (Foundry has added some code to rate-limit rotations).

Akaito commented 3 years ago

Confirmed the fix in 1.5.0! Thanks much! :)