search

shemetz / ZoomPanOptions

FoundryVTT module for zooming and panning better
MIT License
7 stars 8 forks source link

Incompatibility issue with "Lock View" module #31

Closed reubzilla closed 2 years ago

reubzilla commented 3 years ago

Lock View module doesn't work when ZoomPanOptions is installed.

Portacustos1 commented 2 years ago

have reproduced this issue, is there any chance of fixing this as one of our players is new from from roll20 really likes to moan a lot, and it would save us a lot of headaches lol

shemetz commented 2 years ago

Issue on LockView's Github: https://github.com/CDeenen/LockView/issues/46

I believe I can try to solve the incompatibility, but I'll wait until after LockView updates to Foundry v9, as some breaking changes might have happened.

Portacustos1 commented 2 years ago

hey :)

My player keeps asking me if this is fixed yet, I noticed LockView was updated, I don't know if you ever had a chance to look back at this?

CyricPL commented 2 years ago

Adding to this thread - both of these modules are must haves for me!

jocolamarco commented 2 years ago

+1

shemetz commented 2 years ago

I'm still waiting for LockView to use LibWrapper as a dependency, but since a long time has passed without it happening, I decided to add a workaround in my own module that should fix the problem for most users.

Now, if ZoomPanOptions detects this conflict, it will attempt to resolve it by disabling zoom/pan for non-GM users as long as the scene flag 'lockZoom'/'lockPan' is set to true.

Added this in ZoomPanOptions v1.8.4.

Please let me know if this fixes the problems!

CyricPL commented 2 years ago

I'm still waiting for LockView to use LibWrapper as a dependency, but since a long time has passed without it happening, I decided to add a workaround in my own module that should fix the problem for most users.

Now, if ZoomPanOptions detects this conflict, it will attempt to resolve it by disabling zoom/pan for non-GM users as long as the scene flag 'lockZoom'/'lockPan' is set to true.

Added this in ZoomPanOptions v1.8.4.

Please let me know if this fixes the problems!

It appears that the two are working correctly based on my initial testing. I still get the compatibility warning message, but that's to be expected. Thanks!