shemetz / pf2e-extempore-effects

FoundryVTT pf2e module
MIT License
9 stars 8 forks source link

Chat spammed with expired notifications when not relevant #34

Closed Qenthel94 closed 4 months ago

Qenthel94 commented 9 months ago

Previously there was an option to only have secret effects post a notification in chat, which was great as they were the most relevant ones to get a reminder now. Now there is just "all effect" or "no effects" option and it causes some issues with player effects. With stuff like 8 hour long buffs, treat wounds/battle medicine immunity etc every time a longer amount of time passes the chat gets flooded with like 20 messages with maybe 2 being relevant for the effect to be re-applied. ;/ Is there a way to go back to the having a notification only for secret effects?

shemetz commented 9 months ago

Dang, when I removed it I thought there was no legitimate use case, but you're proving me wrong.

I think limiting it only to secret effects is bad though, because many people play with non-secret afflictions and want the reminders for them.

Perhaps I should add a list of "don't remind me when these expire" effects, which is hardcoded to include the treat wounds immunity effect and anything else suggested here?

Qenthel94 commented 9 months ago

The limiting to secret effects could just be an option, like it used to be, right? Then ppl who play with public afflictions can just continue as they do now. Having to maintain a hardcoded list of effects might be a bit much, especially on higher levels where players have a gazillion buffs, effects, item cooldown timers, immunity timers etc.

shemetz commented 4 months ago

Okay, I re-added this setting in the new v1.8.4 (no idea what took me so long...), the default is just to remind on all effects rather than only secret ones.