search

shenango / caladan

Interference-aware CPU scheduling that enables performance isolation and high CPU utilization for datacenter servers
Apache License 2.0
117 stars 50 forks source link

Changing deprecated llvm_asm usage to asm #10

Closed gohar94 closed 1 year ago

gohar94 commented 2 years ago

The llvm_asm package is deprecated (more info here) in favor of asm (docs). This PR updates the relevant calls to llvm_asm to use the new asm package instead.

One thing to note is, now the default syntax is not AT&T; it's Intel. Therefore all usage of asm now explicitly passes options(att_syntax) to keep the same functionality as before.

akshayknarayan commented 1 year ago

btw, this is fixed in the "dev" branch of this repo: https://github.com/shenango/caladan/blob/0275db8de63179ec0f4352a00d52eacbd3531423/bindings/rust/src/lib.rs