shenango / caladan

Interference-aware CPU scheduling that enables performance isolation and high CPU utilization for datacenter servers
Apache License 2.0
117 stars 50 forks source link

Fix UNIX socket abstract path #19

Closed hsadok closed 1 month ago

hsadok commented 3 months ago

There is an issue with how the UNIX socket abstract path is constructed. As it is, the abstract path is just a sequence of \0. It is supposed to just start with \0 and have a meaningful name after.

You can check this by running caladan and then executing the following command:

sudo lsof -U | grep @

You will see some that are just @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@. Which is a string of \0.

joshuafried commented 1 month ago

Merged, thank you!