shenanigans-be / miltydraft

19 stars 18 forks source link

fix: declare name property on GeneratorConfig #25

Closed HaeckelK closed 11 months ago

HaeckelK commented 11 months ago

On PHP 8.2.10

appuser@5bfa6b42e92d:/app$ php --version
PHP 8.2.10 (cli) (built: Sep  7 2023 05:57:10) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.10, Copyright (c) Zend Technologies

getting error re deprecation of dynamic properties, which are used by GeneratorConfig image

dynamic properties deprecated in 8.2.0 https://www.php.net/manual/en/language.oop5.properties.php#language.oop5.properties.dynamic-properties

this PR fixes by declaring name property on GeneratorConfig.