shenanigans-be / miltydraft

19 stars 18 forks source link

Object-oriented programming refactoring #32

Closed FrancoisCossette closed 5 months ago

FrancoisCossette commented 6 months ago

Moved classes into their own separated files, created a Draft class and cleaned some code. Draft computes some properties on demand instead of storing them, which prevents invalid state like for example having "done" set to true but still having picks to do. There is still much to do, but backward compatibility was a priority.

Please feel free to ask any additional details or request changes.

PHP 8.1 needed

shenanigans-be commented 5 months ago

Merged! FYI: I changed some things around (to personal preference) but this is really good work. Thank you so much!