shendurelab / LACHESIS

The LACHESIS software, as described in Nature Biotechnology (http://dx.doi.org/10.1038/nbt.2727)
Other
76 stars 33 forks source link

QuickDotplot fails if home directory doesn't have a bin subdir #8

Open s-andrews opened 9 years ago

s-andrews commented 9 years ago

There is a bug in QuickDotplot. The lines:

my $script_file = "$ENV{'HOME'}/bin/QuickDotplot.R"; write_R_script($script_file);

..cause a failure if the user running the program doesn't already have a directory called 'bin' in their home directory. I can hack this to work by either creating that dir or changing it to:

my $script_file = "$ENV{'HOME'}/QuickDotplot.R";

..but this is still buggy as if two instances of the program run at the same time then they'll fight for that filename and you'll get unwanted results. This should be fixed by generating a proper File::Temp based temporary file for the R script rather than having a hard coded name.