search

shenef / SoS-TAS

Sea of Stars TAS
3 stars 0 forks source link

cleans up beginning of the game fights, appraisals, etc #106

Closed Eein closed 12 months ago

Eein commented 12 months ago

I have a note explaining my future intentions with handling custom encounters. We can discuss this further in the discord.

Refactoring:

Routing change: basically what was occuring where zale got stuck, is it would get stuck in the mash code for exiting the ladder because movement was complete before the battle; this sets it to wait until the character moves after the battle and it will switch over to the ladder sequence.

Notable bugs: still has issues with sunball timing, sometimes its good, sometimes it isn't. Need better detection when to start counting after the infographic goes away..

shenef commented 12 months ago

when trying to start the TAS from the GUI

Traceback (most recent call last):
  File "E:\SoS-TAS\main.py", line 40, in <module>
    menu_manager.run()
  File "E:\SoS-TAS\GUI\menu.py", line 51, in run
    menu.run(top_level=True)
  File "E:\SoS-TAS\GUI\menu.py", line 36, in run
    done = self.active.run()
           ^^^^^^^^^^^^^^^^^
  File "E:\SoS-TAS\GUI\menu.py", line 35, in run
    return self.execute(top_level)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\SoS-TAS\route\TAS.py", line 102, in execute
    self.init_TAS()
  File "E:\SoS-TAS\route\TAS.py", line 151, in init_TAS
    EvermistIsland(),
    ^^^^^^^^^^^^^^^^
  File "E:\SoS-TAS\route\evermist_island\intro.py", line 893, in __init__
    IntroMountainTrail(),
    ^^^^^^^^^^^^^^^^^^^^
  File "E:\SoS-TAS\route\evermist_island\intro.py", line 43, in __init__
    SeqCombatAndMove(
  File "E:\SoS-TAS\engine\combat\combat_and_move.py", line 74, in __init__
    self.combat_controller = CombatController()
                             ^^^^^^^^^^^^^^^^^^
  File "E:\SoS-TAS\engine\combat\combat_controller.py", line 30, in __init__
    self.reasoner = SoSReasoner(combat_manager)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: SoSReasoner.__init__() takes 1 positional argument but 2 were given