search

shenef / SoS-TAS

Sea of Stars TAS
3 stars 0 forks source link

Moonrang fails #140

Closed orkaboy closed 10 months ago

orkaboy commented 11 months ago

As I routed Moorlands and onwards, I would frequently and very reliably see Moonrang getting into a bad state. Valere would launch the attack, try to deflect very early (before the enemy was even hit), then miss on the return.

At this point, the TAS presumably thinks that the spell is still casting? Either that or it thinks that Valere is still selectable. It ends up in a loop selecting between Zale and Garl, without actually committing to a new attack.

Eein commented 11 months ago

the loop between selecting zale and garl is what i believe to be the 'shadow character' issue, where it thinks theres more characters to consider than there actually is - i'll be updating this in the future to fix _read_players() in combat_manager

Eein commented 11 months ago

Not the shadow character issue. related to _read_back_to_slot, need to find a better way to confirm the attack has ended

Eein commented 11 months ago

Should be fixed by #158 - leaving this ticket open for tracking

orkaboy commented 10 months ago

I'd say we can close this now; the issue appears to be solved.