search

shenef / SoS-TAS

Sea of Stars TAS
3 stars 0 forks source link

Memory: New dialog #151

Open orkaboy opened 11 months ago

orkaboy commented 11 months ago

NewDialogManager.dialog_open doesn't always seem to trigger. I'm using it in SeqSelectOption, and I've seen it fail to detect a dialog opening on some runs. Restarting the game solves the issue, so there might be a bad/unreliable pointer path involved.

Eein commented 11 months ago

interesting - i'm using the onDialogClose pointer (if its not 0x0) do you have any specific place its not working. it does flash on an off alot and seemed pretty specific.

orkaboy commented 11 months ago

I remember pretty explicitly ignoring the flag for the placing of crystals in Wizard Lab, next to the save point there. Not sure if that was this bug or if those work differently.

The place I saw it that caused the issue was the tutorial skip dialogs with Erlina and Brugaves, right before the final trials.

Eein commented 11 months ago

excellent, i'll see if theres a place we can hook up to there as well and use an or on the check

Eein commented 11 months ago

i ran the tas today and had no trouble with the tutorial skips

orkaboy commented 11 months ago

Yeah, this one is not very consistent.

Eein commented 11 months ago

I’ll keep an eye out then. If i can replicate ill dig deeper into it

orkaboy commented 10 months ago

Saw this again when trying to interact with the sandwich ingredients in Haunted Mansion.