shenghaoc / pe

0 stars 0 forks source link

Savings calculation can be improved. #1

Open shenghaoc opened 4 years ago

shenghaoc commented 4 years ago

I believe it is the case that coupons can be spent on items that are worth less than the coupon's value (assuming there's no minimum amount spent required). And in that case you would not receive any refund for the excess value of the coupon. Therefore, when I entered $5 for the "used" command, the app should not report that, for a $10 coupon, $10 has been saved. It should be $5 instead. Screenshot from 2020-04-17 14-22-46.png

nus-pe-bot commented 4 years ago

Team's Response

This is intended behaviour as stating the original amount spent is only necessary for coupons that are represented by a percentage amount. It is clearly stated in the User Guide (section 5.5).

image.png

In the event that you would want to save less than what is reflected on the original coupon, the team suggests you to edit the coupon savings first before entering the used command

Severity has been downgraded as this flaw is more related to the cosmetic representation of savings in the application, which may not reflect that the amount can only be set with the add and edit commands. It is quite ridiculous to consider this a "severity.High" issue as the main used command functionality still works as expected without any major problems

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: See below for my response to why not only is this a valid issue, it is one with very high severity.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: > In the event that you would want to save less than what is reflected on the original coupon, the team suggests you to edit the coupon savings first before entering the used command

I have 100 identical coupons worth $10 each, I want to use one coupon on an item worth $5. Despite indicating that the item is only worth $5, the app insists that I have saved $10. In order to accurately reflect my savings, I have to manually adjust the value of the coupon? And I have to remember the original value myself so that if in the future I purchase items worth for example $7, $10 and $11, I would not mistakenly set the value of the coupon to $11 in the last example? In that case why use your app, why not just manually record my savings? What is your value proposition?

Severity has been downgraded as this flaw is more related to the cosmetic representation of savings in the application

For a coupon management app, exaggerating my savings is not just a cosmetic issue. It is "quite ridiculous" for you to dare to suggest it is so.

Since you refuse to fix this bug or even consider it one, sensible members of your target user group "School of Computing (SoC) students and staff who enjoy managing their coupons with a desktop command-line interface" can either not use your app or they can easily fork your repo, fix this issue and render your app obsolete.

Severity should in fact be very high instead.

There is definitely a case for "saving less."

Allow me to provide an example, a set meal costs $9 and my coupon is worth $10. I could choose to buy a more expensive meal or an additional item to "maximize my savings," however I do not like the more expensive meals, maybe they're all beef and I don't eat beef. I also do not want an additional item because I simply don't want to eat more than I need to. Does it really make sense to spend more for the sake of "saving more"?