search

shenghaoc / pe

0 stars 0 forks source link

Calendar GUI arrows not working #2

Open shenghaoc opened 4 years ago

shenghaoc commented 4 years ago

UPDATE: This bug does not appear without using "goto"

I just tried out the "goto" command according to Appendix F. The command itself worked as expected. However, the left and right arrows themselves do not work. They should not be there if the user is expected to only use "goto". In addition, this feature feels incomplete as a user should be able to conveniently return to the current month and not have to do so like going to any other month. It is unlikely for anyone to want to remain in AD5678. Screenshot from 2020-04-17 14-35-07.png

nus-pe-bot commented 4 years ago

Team's Response

Users are not expected to only use the goto command to navigate the calendar. The arrows on the calendar are included to give users the flexibility to navigate the calendar either using the CLI or the GUI. With this, users are able to conveniently navigate the calendar with both the goto command and the arrows, up to the year 2200 (which users are unlikely to access).

It is also unlikely for anyone to have a coupon that expires in AD5678.

Hence, this bug is unlikely to affect users, with normal usage of Coupon Stash, as this bug will only manifest when users try to access years after 2200. We have downgraded the severity accordingly as it would only appear in rare situations.

Thank you for pointing this out!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Initially I thought the arrows should have worked, but it appears that they failed because you restricted the accessible years to a range that you consider reasonable.

In that case, there are 2 bugs:

  1. Your Instructions for Manual Testing instructs the reader to enter goto my/4-5678, this is type.DocumentationBug with severity.High because a developer following the instructions will always go to a year outside your intended range and be unable to use the calendar until he uses the goto command to go to a year within the range, which you did not mention in both your UG and DG. It could have been any number, e.g. 2103.

  2. The goto command does not implement the same check as the GUI arrows, allowing users to go outside your intended range. This is type.FunctionalityBug with severity.Low as indeed years outside your intended range are unlikely.