search

shenghaoc / pe

0 stars 0 forks source link

No conversion of currency value #4

Open shenghaoc opened 4 years ago

shenghaoc commented 4 years ago

It would be better if exchange rate was considered, currently changing the symbol of the currency is purely cosmetic and may result in unusual prices. Of course, this is a minor issue. Screenshot from 2020-04-17 15-01-56.png

nus-pe-bot commented 4 years ago

Team's Response

We did consider this feature, but in the end we decided it was out of scope as most, if not all, coupons are only defined in terms of one currency, for use in a certain country that only uses that currency

Also, the program is supposed to work without the internet, so it would not be able to retrieve real time exchange rates. Monetary amount is restricted to 2 decimal places, so the conversion could also result in bugs like rounding error

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]