search

shenkarlab / Off-The-record

מה מעסיק את חבריי הכנסת שלנו ומה דעותיהם בתחומים שונים, דרך המילים בהן הם בוחרים להשתמש ברשתות החברתיות
1 stars 1 forks source link

Create a gh-pages branch for QA before pushing to the production server #32

Closed mushon closed 9 years ago

mushon commented 9 years ago

We should be able to browse and QA the content of /WebSite/ on http://shenkarlab.github.io/Off-The-record/WebSite/

nir-jackson commented 9 years ago

it will have the same problem as running it from my machine, the data won't be under the same domain and it won't work. @mushon

mushon commented 9 years ago

@nir-jackson I doubt that. Reading JSON remotely is trivial. Your problem is probably in making sure links are relative when they need to be relative and absolute when they need to be absolute.

Anyway, the code is updated on the Calcalist site (http://viz.calcalist.co.il/otr/web/) please have the whole group @shenkarlab/off-the-record review it, document the last bugs (especially in the case of missing posts, @akariv thinks it might be due to missing posts from Kikar Hamedina) and let's launch this thing. @Amitasulin9 @eldadtzadok @moranbz, please confirm you're seeing this, I want to see you documenting bugs and responding to issues.

nir-jackson commented 9 years ago

@mushon i know its because of missing posts from kikar hamedina. I've mentioned this problem several times.... kikar only has posts from (around) 2012.

i don't see the point of uploading the site to http://shenkarlab.github.io/Off-The-record/WebSite/.

did you also rerun the python scripts? did you delete the old data before as i asked?

akariv commented 9 years ago

yes

On Thu, Mar 5, 2015 at 11:06 AM Nir Jackson notifications@github.com wrote:

@mushon https://github.com/mushon i know its because of missing posts from kikar hamedina. I've mentioned this problem several times.... kikar only has posts from (around) 2012.

i don't see the point of uploading the site to http://shenkarlab.github.io/Off-The-record/WebSite/.

did you also rerun the python scripts? did you delete the old data before as i asked?

— Reply to this email directly or view it on GitHub https://github.com/shenkarlab/Off-The-record/issues/32#issuecomment-77329374 .

mushon commented 9 years ago

Since this issue isn't done, I'm reopening this ticket and marking it to the "After Launch" milestone.