V-slot naming inside DOM template fix

shentao / vue-multiselect

Universal select/multiselect/tagging component for Vue.js

https://vue-multiselect.js.org/

MIT License

6.66k stars 991 forks source link

V-slot naming inside DOM template fix #1679

Open ReyFelipe opened 1 year ago

ReyFelipe commented 1 year ago

Modified the slot names from camelCase to kebab-case due the browser behaviour when you write the template directly inside the DOM. V-slot name is an attribute and the browser normalises that to all-lowercase. Also modified the README.md to display kebab-case instead of camelCase.

ReyFelipe commented 1 year ago

While using this library with some colleagues, we ran into this issue and we think that the requested solution is the best fix. Would be greatly appreciated if you could accept so we can continue using the library.

AlguerGalceran commented 1 year ago

@shentao @akki-jat @mattelen any update for this issue?

mattelen commented 1 year ago

This PR looks good, however, this introduces a breaking change around the naming of slots. The current version we are working towards that supports Vue 3 we want to avoid adding breaking changes where we can (see https://github.com/shentao/vue-multiselect/discussions/1589 for the roadmap). Because of this, I'm keen to hold off releasing this, and have it as part of version 4