search

shentao / vue-multiselect

Universal select/multiselect/tagging component for Vue.js
https://vue-multiselect.js.org/
MIT License
6.65k stars 989 forks source link

fix: Deselection of the preselected group values #1750

Closed chandrabhan-singh-27d closed 4 months ago

chandrabhan-singh-27d commented 5 months ago

Issues:

  1. The custom event 'remove' is not working when emitted from inside the selectGroup method, thus need to call the removeElement method instead.

  2. When removing an element, there is a deep comparison of objects thus need to compare using the JSON.stringify method and then remove the elements from the internalValue array.

Fixes #713

akki-jat commented 5 months ago

@chandrabhan-singh-27d Is there any open issue for the same with the reproducible link. If not then please create the issue first, then we can look into it.

Thanks for the PR.

chandrabhan-singh-27d commented 5 months ago

@chandrabhan-singh-27d Is there any open issue for the same with the reproducible link. If not then please create the issue first, then we can look into it.

Thanks for the PR.

Hi @akki-jat, please find the issue #713. Thanks!

chandrabhan-singh-27d commented 5 months ago

Hi @akki-jat, just checking if we can merge this as we are using the library in our app in productions and a quick merge can help us minimizing the fix replication at each instance. As mentioned earlier, here is the issue #713. Appreciate the help!

akki-jat commented 4 months ago

Closing as we have new PR (https://github.com/shentao/vue-multiselect/pull/1754) for the same.

akki-jat commented 4 months ago

@chandrabhan-singh-27d Please check if PR https://github.com/shentao/vue-multiselect/pull/1754 fixes the issue or not.

chandrabhan-singh-27d commented 4 months ago

Yes, it does. Thanks for fixing the issue @akki-jat.