shenwei356 / csvtk

A cross-platform, efficient and practical CSV/TSV toolkit in Golang
http://bioinf.shenwei.me/csvtk
MIT License
999 stars 84 forks source link

Possible typo in documentation for mutate2 #215

Closed Gavin-Holt closed 1 year ago

Gavin-Holt commented 1 year ago

Hi

The documentation for mutuate2 includes an example with named fields:

$ cat testdata/names.csv  \
    | csvtk mutate2 -n full_name -e ' $first_name + " " + $last_name '

Do these named fields need curly brackets?

$ cat testdata/names.csv  \
    | csvtk mutate2 -n full_name -e ' ${first_name} + " " + ${last_name} '

Kind Regards Gavin Holt

shenwei356 commented 1 year ago

Thank you.

There's no need. Both works since csvtk v0.25.0.

[shenwei@mBio csvtk]$ cat testdata/names.csv  \        
    | csvtk mutate2 -n full_name -e ' $first_name + " " + $last_name '
id,first_name,last_name,username,full_name
11,Rob,Pike,rob,Rob Pike
2,Ken,Thompson,ken,Ken Thompson
4,Robert,Griesemer,gri,Robert Griesemer
1,Robert,Thompson,abc,Robert Thompson
NA,Robert,Abel,123,Robert Abel

[shenwei@mBio csvtk]$ cat testdata/names.csv  \            
    | csvtk mutate2 -n full_name -e ' ${first_name} + " " + ${last_name} '
id,first_name,last_name,username,full_name
11,Rob,Pike,rob,Rob Pike
2,Ken,Thompson,ken,Ken Thompson
4,Robert,Griesemer,gri,Robert Griesemer
1,Robert,Thompson,abc,Robert Thompson
NA,Robert,Abel,123,Robert Abel