search

shenwei356 / kmcp

Accurate metagenomic profiling && Fast large-scale sequence/genome searching
https://bioinf.shenwei.me/kmcp
MIT License
176 stars 13 forks source link

A minor issue on console messages #8

Closed zhanxw closed 2 years ago

zhanxw commented 2 years ago

Thanks for developing this tool.

When I inputted an empty file, the console outputs: ... 11:27:03.868 [WARN] no invalid sequences in file: input.fq.gz ...

The text should be "no valid sequences" instead of "no invalid sequences"?

shenwei356 commented 2 years ago

Oh, you're right! Thanks for reporting this.

zhanxw commented 2 years ago

Another minor issue in the console message.

Here are some console messages for kmcp search:

... 23:44:29.502 [INFO] -------------------- [main parameters] -------------------- 23:44:29.502 [INFO] minimum query length: 30 23:44:29.502 [INFO] minimum matched k-mers: 10 23:44:29.502 [INFO] minimum query coverage: 0.550000 23:44:29.505 [INFO] minimum target coverage: 0.000000 23:44:29.505 [INFO] minimum target coverage: 0.000000 23:44:29.505 [INFO] -------------------- [main parameters] -------------------- ...

There are duplicated information on minimum target coverage. Not sure if it is intended.

shenwei356 commented 2 years ago

Thank you again!