search

shenwei356 / rush

A cross-platform command-line tool for executing jobs in parallel
https://github.com/shenwei356/rush
MIT License
846 stars 63 forks source link

misc improvements #14

Closed bburgin closed 6 years ago

bburgin commented 6 years ago

  1. Added propagate-exit-status command line arg, default true Propagates child process exit status to rush exit status, so rush fails if a child fails

  2. Added print-retry-output command line arg, default true Prints child output from retries, so users can see what caused retries

  3. Added kill-on-ctrl-c command line arg, default true Toggles child process kill or not

  4. For windows if kill-on-ctrl-c, kill whole child process tree, so we don't orphan child processes

  5. Modified logic to print child output even if commands failed, so users can see what failed

bburgin commented 6 years ago

Hi Wei Shen: Sorry for all the failed pull request attempts. I am stuck on the mac failure below. Any ideas? I don't have a mac to try it out.

Thanks, Brian

shenwei356 commented 6 years ago
bburgin commented 6 years ago

Thanks, Wei Shen. I updated the pull request with fixes to meet your two points:

you don't usr gofmt to format code?
please provide more details of this PR, not in the title.

Brian

shenwei356 commented 6 years ago

Thank you Brian, I have to take some to digest your code before merging.

Some days ago, I met a bug which your improvement 4 may fix. This PR may help a lot, thank you.

shenwei356 commented 6 years ago

Hi, I've updated the travis config, please resubmit the PR to see if travis can pass the test on osx.

shenwei356 commented 6 years ago

A bug both in Linux and Windows

$ echo | ./rush
[ERRO] did not get an exit status int from any child process)
shenwei356 commented 6 years ago

Hi Brian, thanks for you contribution!

The tests passed.