shenxn / ha-dyson

HomeAssitant custom integration for dyson
MIT License
312 stars 59 forks source link

Broken after update to HA 2022.4.0 #119

Closed Ultra9k closed 2 years ago

Ultra9k commented 2 years ago

After the latest update to HA 2022.4.0, continuous monitoring, night mode and air quality target all stopped working.

Edit: and temperature also not working anymore

Ultra9k commented 2 years ago

I then updated the addon to your latest release (0.16.3) and now I get:

Error This integration does not support configuration via the UI. If you followed this link from the Home Assistant website, make sure you run the latest version of Home Assistant.

It's completely broken.

rbnmk commented 2 years ago

I have the same issue since updating to 2022.4.0 and updating to the latest HACS release. Now get this error in the logs on startup:

Setup failed for custom integration dyson_local: Unable to import component: cannot import name 'DysonPurifierHumidifyCoolFormaldehyde' from 'libdyson' (/usr/local/lib/python3.9/site-packages/libdyson/init.py)

Linusten commented 2 years ago

Same issue here...

Unable to import component: cannot import name 'DysonPurifierHumidifyCoolFormaldehyde' from 'libdyson' (/usr/local/lib/python3.9/site-packages/libdyson/init.py)

sultanhq commented 2 years ago

as a temp fix, i used vs-code (on my Home assistant) and removed all references (imports and or staments) to DysonPurifierHumidifyCoolFormaldehyde in an all files search.... now it's all back to working (for now until an update )`

obviously that particular machine (DysonPurifierHumidifyCoolFormaldehyde) won't work though :-(

BeHappy2021 commented 2 years ago

Thanks @sultanhq. This worked for me.

Ultra9k commented 2 years ago

as a temp fix, i used vs-code (on my Home assistant) and removed all references (imports and or staments) to DysonPurifierHumidifyCoolFormaldehyde in an all files search.... now it's all back to working (for now until an update )`

obviously that particular machine (DysonPurifierHumidifyCoolFormaldehyde) won't work though :-(

Even the things that stopped working afte the latest HA update? (Continuous monitoring, temperature, etc?)

BeHappy2021 commented 2 years ago

Even the things that stopped working afte the latest HA update? (Continuous monitoring, temperature, etc?)

Yes. Only thing missing is air quality.

Ultra9k commented 2 years ago

Didn't work for me. I did that and then nothing worked anymore. I guess I'll have to wait for a fix to be released...

fwump38 commented 2 years ago

I spent a long time trying to use this and libdyson to include the latest changes before they were released and I could never get it to work. I believe that this part of manifest.json which pulls in the latest changes in libdyson isn't working properly

HACS does support using a github tag or branch as the requirements but I think it's formatted incorrectly. Even when formatted correctly it still gives me the error that it can't import DysonPurifierHumidifyCoolFormaldehyde

Maybe @austinbeam can chime in as they were the one to add the support for that device and I think it was working for them.

I suspect that libdyson needs a new release pushed to pypi so the requirements for HACS can be input in the "normal" way and this issue might resolve itself... cc: @kakise

Sadly, I'm waiting on DysonPurifierHumidifyCoolFormaldehyde because that's the device I have and I can't get this integration to work otherwise.

austinbeam commented 2 years ago

I think it needs the spaces, but it failed checks so I tried it without them (which also failed, but was merged). I have confirmed it is working with the spaces and it's been flawless for me.

Sorry for the trouble @fwump38 -- hope this helps.

https://github.com/shenxn/ha-dyson/commit/4e135cf4254c41a692a54e3a3485bf3c1bb654bd

Edit: just scrolled up and read the earlier part of the thread. It does appear that temperature broke with my 2022.4 upgrade also, but the other things mentioned are still working.

austinbeam commented 2 years ago

I think we can all agree the best fix would be a new libdyson (@shenxn) release and restoring the manifest the way it was before to provide a new ha-dyson release. Admittedly, my approach was a hack, but I did what I could to get my PH03 working. I tried to get the manifest changes to pass checks but they would not. I still believe https://github.com/shenxn/ha-dyson/commit/e742bae807758bc8a3d109ae30da602c5951ad01 has the right formatting although it did not pass checks because that's what I am using and it works. The temperature issue seems to be something else, at least for me.

Let me know how I can help folks, hate that it's causing trouble for anyone.

BeHappy2021 commented 2 years ago

I'd like to thank you and the others putting the work in so that we have an integration that works at all with our devices. There's been a little glitch this time but these things happen.

austinbeam commented 2 years ago

As an interim fix for those dealing with issues and needing PH03/PH04 support, one option to consider is trying my fork.

I know this is not a long-term fix, but hopefully it might help someone if you just want to get it working. I went ahead and merged @Flameeyes outstanding pull request in this fork as well. Hopefully the main repo can get back in order soon. Everything is functional again for me. Good luck folks.

Flameeyes commented 2 years ago

Sadly, I'm waiting on DysonPurifierHumidifyCoolFormaldehyde because that's the device I have and I can't get this integration to work otherwise.

https://github.com/shenxn/ha-dyson/issues/115#issuecomment-1090833923 should do the trick for that.

Cully81 commented 2 years ago

Hi,

After the update to HA 2022.4.1 everything works fine for me again

Anto79-ops commented 2 years ago

My integration is now back to working after updating 2022.4.1!!

Ultra9k commented 2 years ago

Which integration version?? My 0.16.2 has the same problems with 2023.4.1. Is 0.16.3 working now?

Anto79-ops commented 2 years ago

Yes 0.16.3 now works on 2022.4.1 (for me at least).

Ultra9k commented 2 years ago

Not for me. Just tested it.

atmezferix commented 2 years ago

Yeah and mine, glad you sent the message I hadn't even noticed.

On Fri, 8 Apr 2022 at 15:05, Ultra9k @.***> wrote:

Not for me. Just tested it.

— Reply to this email directly, view it on GitHub https://github.com/shenxn/ha-dyson/issues/119#issuecomment-1092896019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4H4FWLZC524JOCQ3PAQBLVEA4J3ANCNFSM5SXP6OLQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

c0bra99 commented 2 years ago

I updated Home Assistant to 2022.4.1 from 2022.3.7 today, saw all the unavailable dyson entities, then updated ha-dyson to 0.16.3 from 0.16.2. Now on startup I am getting this error in the log:

Setup failed for custom integration dyson_local: Unable to import component: cannot import name 'DysonPurifierHumidifyCoolFormaldehyde' from 'libdyson' (/usr/local/lib/python3.9/site-packages/libdyson/init.py)

I do not use a Formaldehyde sensing device, but it looks like the integration is not loading at all now, every entity is unavailable.

Anto79-ops commented 2 years ago

Perhaps I'll give a bit more information on my system.

I had 0.16.2 on 2022.3.7, working perfectly no problems, then I updated to 2022.4.0, this completely broke the Dyson integration doesn't even load giving the issue of the component Dyson formaldehyde can't import.

There were some suggested fixes which I did not do or attempted to do so I just waited.

This morning 2022.4.1 was available updated it then after restart, the Dyson integration was working perfectly including temperature reporting.

c0bra99 commented 2 years ago

I have rolled ha-dyson back to 0.16.2 from 0.16.3 (on home assistant 2022.4.1). At least the useful temperature/humidity/on off switch entities are back working again, but now there are startup errors:

These startup errors do not seem to impact the important entities from working for me.. I'll leave mine on 0.16.2 for now.

BeHappy2021 commented 2 years ago

All working fine for me on 2022.4.1 and 0.16.3. As I'd made edits to the source files I removed everything (first the devices, then the integration from HACS) restarted then added 0.16.3 and the devices again. Everything now appears to be working fine.

Ultra9k commented 2 years ago

Can't get it to work...

Kakise commented 2 years ago

Should work on v0.16.4 as mentioned in #115

yosoyez commented 2 years ago

Started working for me after the update as well

c0bra99 commented 2 years ago

ha-dyson version 0.16.4-4 with home assistant 2022.4.1, all startup errors are gone and all entities are back to working!

Thank you!