search

shenxn / protonmail-bridge-docker

ProtonMail IMAP/SMTP Bridge Docker container
GNU General Public License v3.0
395 stars 79 forks source link

README is incorrect for creating container #92

Open aferrebee opened 12 months ago

aferrebee commented 12 months ago

The README file say to run docker run -d --name=protonmail-bridge -v protonmail:/root -p 1025:25/tcp -p 1143:143/tcp --restart=unless-stopped shenxn/protonmail-bridge

but this causes the wrong port to be exposed for the contain. Since 1025 and 1143 are mapped to 25 and 143 with socat so the README commands should be docker run -d --name=protonmail-bridge -v protonmail:/root -p 25:25/tcp -p 143:143/tcp --restart=unless-stopped shenxn/protonmail-bridge

therealstein commented 11 months ago

I see nothing incorrect or wrong. It’s totally your decision how to map the exposed ports.

graememclaughlin commented 6 months ago

I would note that there is a difference here on port selection. If I map to port 25 on the container (instead of the configured 1025), I am able to connect. Not so if I map 1025:1025. I'm guessing socat is fooling protonmail-bridge into accepting the connection from an "outside" machine.