search

shepherdjay / ipfromwebpage

Simple script that scrapes a web page for IP addresses and prints aggregate result.
MIT License
2 stars 6 forks source link

Added IPv6 support #12

Closed noahlvb closed 7 years ago

noahlvb commented 7 years ago

Added support for IPv6 according to issue #11

shepherdjay commented 7 years ago

@noahlvb let me know if you need any assistance with the tests on this, at a quick glance your implementation looks solid.

noahlvb commented 7 years ago

Some assistance would be great since I have never really made tests my self for python.

codecov[bot] commented 7 years ago

Codecov Report

Merging #12 into master will decrease coverage by 1.42%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage     100%   98.57%   -1.43%     
==========================================
  Files           2        2              
  Lines          54       70      +16     
  Branches        8       12       +4     
==========================================
+ Hits           54       69      +15     
- Partials        0        1       +1
Impacted Files Coverage Δ
ipfromwebpage/ipfromwebpage.py 98.48% <94.11%> (-1.52%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38c3a9e...1f7fd98. Read the comment docs.

shepherdjay commented 7 years ago

Hey looks like you got the tests adjusted appropriately. I'm going to go ahead and pull these in. Not sure why codecov is throwing a partial