search

shepherdjay / ipfromwebpage

Simple script that scrapes a web page for IP addresses and prints aggregate result.
MIT License
2 stars 6 forks source link

Updated regex command for ipv6_from_string #16

Closed garrett-phoonswadi closed 7 years ago

garrett-phoonswadi commented 7 years ago

Sorry this is my first time trying to collaborate for Hacktober2017 let me know if this works!

codecov[bot] commented 7 years ago

Codecov Report

Merging #16 into master will increase coverage by 1.36%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   95.89%   97.26%   +1.36%     
==========================================
  Files           2        2              
  Lines          73       73              
  Branches       12       12              
==========================================
+ Hits           70       71       +1     
  Misses          2        2              
+ Partials        1        0       -1
Impacted Files Coverage Δ
ipfromwebpage/ipfromwebpage.py 97.1% <100%> (+1.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fa69a0...86c19c7. Read the comment docs.

shepherdjay commented 7 years ago

I'm going to actually pull this without squash into the ipv6tests branch to test it against some known use cases. Thanks for looking into this