search

shepherdjay / ipfromwebpage

Simple script that scrapes a web page for IP addresses and prints aggregate result.
MIT License
2 stars 6 forks source link

Made basic pytest conversions for TestExtractWebPageData #43

Closed Alig1493 closed 5 years ago

Alig1493 commented 5 years ago

Addressing issue #21.

codecov[bot] commented 5 years ago

Codecov Report

Merging #43 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files           1        1           
  Lines          78       78           
  Branches       10       10           
=======================================
  Hits           64       64           
  Misses         13       13           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 389a5ac...ae0966f. Read the comment docs.

Alig1493 commented 5 years ago

https://github.com/shepherdjay/ipfromwebpage/pull/44

@shepherdjay This PR might help fix our failed travis issue for python3.4.

shepherdjay commented 5 years ago

This failed because of poetry - Can you remove 3.4 from the list of travis version to run and then we will see if this runs again without issue.

shepherdjay commented 5 years ago

Thanks for your contribution! This looks good.