shepherdjerred / astro-opengraph-images

Generate Open Graph images for your Astro site
https://www.npmjs.com/package/astro-opengraph-images
GNU General Public License v3.0
31 stars 2 forks source link

Windows support #25

Closed FabulousCodingFox closed 4 months ago

FabulousCodingFox commented 4 months ago

handlePage takes the URL parameter "dir" without properly converting it to a file path. This results in an incompatibility with filesystems that dont begin the root path with a "/" char.

All URL objects should be converted to an absolute file path using fileURLToPath from the url package included with node.

See https://github.com/withastro/astro/issues/3607

shepherdjerred commented 4 months ago

Thank you for adding this.

shepherdjerred commented 4 months ago

This is released as part of 1.7.0. It should be on npm shortly.