search

shepmaster / jetscii

A tiny library to efficiently search strings for sets of ASCII characters and byte slices for sets of bytes.
Apache License 2.0
113 stars 20 forks source link

Build fails on i686 #34

Closed ignatenkobrain closed 5 years ago

ignatenkobrain commented 5 years ago 
BUILDSTDERR: error[E0432]: unresolved import `std::arch::x86_64`
BUILDSTDERR:  --> src/simd.rs:6:11
BUILDSTDERR:   |
BUILDSTDERR: 6 |     arch::x86_64::{
BUILDSTDERR:   |           ^^^^^^ could not find `x86_64` in `arch`
ignatenkobrain commented 5 years ago

I believe it is because #[cfg(any(target_arch = "x86", target_arch = "x86_64"))] is wrong, on x86 you don't get arch::x86_64.

shepmaster commented 5 years ago

That's totally believable. I wonder if there's a way to easily test x86 in Travis (or other CI).

Since you have an x86 system on hand, would it be easy for you to patch the crate to use the correct imports?

ignatenkobrain commented 5 years ago

I think people just use cross-compilation in travis. Probably check what ripgrep / regex and such. Or libc.

Going to patch it out now.

ignatenkobrain commented 5 years ago

@shepmaster ok, #35 it is :)