search

shepmaster / snafu

Easily assign underlying errors into domain-specific errors while adding context
https://docs.rs/snafu/
Apache License 2.0
1.4k stars 60 forks source link

Add errors stabilized in 1.34 to the core Error shims #327

Closed shepmaster closed 2 years ago

shepmaster commented 2 years ago

Fixes #324

netlify[bot] commented 2 years ago

✔️ Deploy Preview for shepmaster-snafu ready!

🔨 Explore the source changes: 76c02d8e818ab892c5e1cae2edec047ee9aed576

🔍 Inspect the deploy log: https://app.netlify.com/sites/shepmaster-snafu/deploys/6216f0b87782c00008cdf840

😎 Browse the preview: https://deploy-preview-327--shepmaster-snafu.netlify.app

FedericoPonzi commented 2 years ago

Thanks a lot for the quick pr! Unfortunately I cannot test it because it's not building, I'm getting the same error from the CI

error: no rules expected the token `core`
  --> src/no_std_error.rs:37:5
   |
17 | macro_rules! impl_error {
   | ----------------------- when calling this macro
...
37 |     core::array::TryFromSliceError, // 1.34
   |     ^^^^ no rules expected this token in macro call

error: could not compile `snafu` due to previous error

Exit status: 101
shepmaster commented 2 years ago

because it's not building

Well, that's embarrassing. Let's try that again.