search

shepmaster / snafu

Easily assign underlying errors into domain-specific errors while adding context
https://docs.rs/snafu/
Apache License 2.0
1.39k stars 60 forks source link

Add missing generics and trait bounds to `FromString` impl #442

Closed chanced closed 6 months ago

chanced commented 6 months ago

Fixes #441

I'm still pretty ignorant when it comes to proc macros but I think this is correct. I need to write some tests tho.

netlify[bot] commented 6 months ago

Deploy Preview for shepmaster-snafu ready!

Name Link
Latest commit 61388f50a95ea63c83664e7ded0790cd0b6d3dc2
Latest deploy log https://app.netlify.com/sites/shepmaster-snafu/deploys/65ef4aa31f3ae500088a5ec6
Deploy Preview https://deploy-preview-442--shepmaster-snafu.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chanced commented 6 months ago

I'm still incredibly new to proc macros - is having a variant that covers the code gen enough for code cov?

shepmaster commented 6 months ago

Yeah, having a test that failed (even just failed to build) before your code change and passes afterwards is fine.